Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show scheduled change request #3118

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Dec 8, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Scheduled change requests will now show the live and scheduled change
  • Published change requests will now show the change request regardless whether it has been committed or not
  • Committed change requests no longer have CTAs

How did you test this code?

  • View a closed change request
  • Viewed a scheduled change

image

Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 5:02pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 5:02pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 5:02pm

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Uffizzi Preview deployment-42428 was deleted.

Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a small change that has a side effect of a larger diff. I didn't see any logical errors but I have one bit of feedback around the naming of one part.

Comment on lines +700 to +701
{isMv &&
mvData.map((v, i) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understanding you're just dealing with existing code and changing the tabbing, but since it is involved with the PR I'll just mention that the name isMv and mvData and map((v, i) => ... make this section sorta hard to understand.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this is essentially showing differences in change request on multivariate flag variations.

@kyle-ssg kyle-ssg enabled auto-merge December 8, 2023 17:34
@kyle-ssg kyle-ssg added this pull request to the merge queue Dec 8, 2023
Merged via the queue into main with commit efddf13 Dec 8, 2023
15 checks passed
@kyle-ssg kyle-ssg deleted the fix/show-scheduled-change-request branch December 8, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The detail view for the scheduled feature changes does not show the upcoming value
2 participants