fix(webhook/logging): log response code only if response is not none #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gagantrivedi
requested review from
a team and
matthewelwell
and removed request for
a team
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3354 +/- ##
===========================================
- Coverage 95.96% 18.00% -77.96%
===========================================
Files 1071 990 -81
Lines 32743 28561 -4182
===========================================
- Hits 31421 5143 -26278
- Misses 1322 23418 +22096 ☔ View full report in Codecov by Sentry. |
|
Uffizzi Preview |
| @@ -22,9 +22,10 @@ def __init__(self, config: WebhookConfiguration): | |||
|
|
|||
| def _identify_user(self, data: typing.Mapping) -> None: | |||
| response = call_integration_webhook(self.config, data) | |||
There was a problem hiding this comment.
Under what circumstances does call_integration_webhook return None ?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah ok, interesting. This solution seems fine for now I guess, but perhaps my original solution was wrong, and we should just try/except the call_integration_webhook function 🤔
matthewelwell
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Handle
call_integration_webhookreturningNonein case of failuredetails: https://flagsmith.sentry.io/issues/4874822372/?project=5544478&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=24h&stream_index=0
How did you test this code?
I have tested it manually but writing a test for this will involve unit testing a private method. Keen to get some input on this