fix: handle InfluxDBError when writing data #3788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3788 +/- ##
==========================================
+ Coverage 95.91% 95.93% +0.01%
==========================================
Files 1102 1103 +1
Lines 34789 34832 +43
==========================================
+ Hits 33369 33415 +46
+ Misses 1420 1417 -3 ☔ View full report in Codecov by Sentry. |
khvn26
reviewed
Apr 17, 2024
Co-authored-by: Kim Gustyr <[email protected]>
zachaysan
approved these changes
Apr 17, 2024
api/tests/unit/app_analytics/test_unit_app_analytics_influxdb_wrapper.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Catch InfluxDBError when writing errors so we don't spam sentry for e.g. rate limiting errors.
How did you test this code?
Added a unit test. Note that the test is pretty crude for now as the caplog fixture is poor, but it achieves what we need.