Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: versioned remove segment override #4063

Merged
merged 1 commit into from
May 31, 2024
Merged

fix: versioned remove segment override #4063

merged 1 commit into from
May 31, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes reordering and deleting a versioned segment override caused an exception in the fronted

How did you test this code?

  • Create a feature with 2 segment overrides
  • Reorder the segment overrides
  • Delete a segment override

@vercel Vercel
Copy link

vercel bot commented May 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 1:51pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 1:51pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 1:51pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label May 31, 2024
@kyle-ssg kyle-ssg requested a review from matthewelwell May 31, 2024 13:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 31, 2024 •
edited
Loading

Uffizzi Preview deployment-52487 was deleted.

@kyle-ssg kyle-ssg added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit e4cd25a May 31, 2024
21 checks passed
@kyle-ssg kyle-ssg deleted the fix/versioned-delete-segment-override-and-reorder branch May 31, 2024 15:34
@dabeeeenster dabeeeenster mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolodato rolodato rolodato approved these changes

@matthewelwell matthewelwell Awaiting requested review from matthewelwell

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @rolodato