Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Keep segment modal open on create / edit, add segment name to modal #4109

Merged
merged 1 commit into from
Jun 13, 2024
Merged

feat: Keep segment modal open on create / edit, add segment name to modal #4109

merged 1 commit into from
Jun 13, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jun 5, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Creating/updating a segment keeps the modal open
  • Creating a segment updates the modal title and shows as edit segment
  • Edit segment now has the name in the title

@vercel Vercel
Copy link

vercel bot commented Jun 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 11:15am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 11:15am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 11:15am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Jun 5, 2024
This was linked to issues Jun 5, 2024
Show segment name when editing #3918
Closed
Segment modal is closed after editing or creation #3922
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024 •
edited
Loading

Uffizzi Preview deployment-52665 was deleted.

@kyle-ssg kyle-ssg requested a review from rolodato June 11, 2024 07:40
@kyle-ssg kyle-ssg added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit 1daedc2 Jun 13, 2024
21 checks passed
@kyle-ssg kyle-ssg deleted the feat/improve-edit-segment-modal branch June 13, 2024 09:31
@dabeeeenster dabeeeenster mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolodato rolodato rolodato approved these changes

Assignees
No one assigned
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segment modal is closed after editing or creation Show segment name when editing
2 participants
@kyle-ssg @rolodato