feat: Set default billing terms for missing info cache #4614
Conversation
zachaysan
requested review from
matthewelwell
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
github-actions
bot
added
api
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4614 +/- ##
========================================
Coverage 97.16% 97.17%
========================================
Files 1160 1162 +2
Lines 40137 40275 +138
========================================
+ Hits 39000 39138 +138
Misses 1137 1137 ☔ View full report in Codecov by Sentry. |
|
I've read the description of this PR a few times and I can't make any sense of it? Can you reword it at all?
|
| def test_get_usage_data_returns_empty_list_when_unset_subscription_information_cache( | ||
| period: str, | ||
| @pytest.mark.freeze_time("2023-01-19T09:09:47.325132+00:00") | ||
| def test_get_usage_data_returns_empty_list_when_unset_subscription_information_cache_for_previous_billing_period( |
There was a problem hiding this comment.
I think the name of this test (and the following one) needs updating to reflect the new behaviour?
There was a problem hiding this comment.
Nice catch. Fixed.
github-actions
bot
added
feature
matthewelwell
deleted the
feat/set_default_billing_terms_for_missing_info_cache
branch
Changes
This updates the billing period API usage to 30 day defaults for the current billing period and previous billing period.
How did you test this code?
Split a test into two separate tests and verified the mocked calls.