-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript Rewrite #70
base: v4
Are you sure you want to change the base?
Conversation
* Add files * Include files not ready for others to review Co-authored-by: Phil <[email protected]>
* Move to TypeScript * Update ESLint and GitIgnore * Remove Deno * Add Snyk configuration * Add badge icons * Rewrite commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin good!
* Add ban command * Add default permissions for ban and setup * Add ephemeral tags where needed * Add guild settings db model * Add model typing explanation comments * Add guild authentication util function * Add interaction master handler * Update config references * Update model typings * Update commands to spread arguments
await client.models.ban.findOrCreate({ | ||
where: { | ||
guildId: interaction.guild.id, | ||
targetId: target.id, | ||
reason: options.getString('reason') || null | ||
} | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this even needed if it emits the guildBanAdd
event?
// Remove from database | ||
await client.models.ban.destroy({ | ||
where: { | ||
targetId: b.user.id, | ||
guildId: interaction.guild.id | ||
} | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as with ban.ts
, is this needed since Discord emits the event?
No description provided.