Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript Rewrite #70

Open
wants to merge 8 commits into
base: v4
Choose a base branch
from
Open

TypeScript Rewrite #70

wants to merge 8 commits into from

Conversation

totallytavi
Copy link
Contributor

No description provided.

totallytavi and others added 5 commits June 10, 2023 16:09
* Add files
* Include files not ready for others to review

Co-authored-by: Phil <[email protected]>
* Move to TypeScript
* Update ESLint and GitIgnore
* Remove Deno
* Add Snyk configuration
* Add badge icons
* Rewrite commands
src/functions/load.ts Outdated Show resolved Hide resolved
src/functions/load.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/functions/load.ts Outdated Show resolved Hide resolved
Copy link
Member

@phil-flip phil-flip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good!

src/commands/alias.ts Outdated Show resolved Hide resolved
src/commands/avatar.ts Outdated Show resolved Hide resolved
src/commands/banner.ts Outdated Show resolved Hide resolved
* Add ban command
* Add default permissions for ban and setup
* Add ephemeral tags where needed
* Add guild settings db model
* Add model typing explanation comments
* Add guild authentication util function
* Add interaction master handler
* Update config references
* Update model typings
* Update commands to spread arguments
Comment on lines +63 to +69
await client.models.ban.findOrCreate({
where: {
guildId: interaction.guild.id,
targetId: target.id,
reason: options.getString('reason') || null
}
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this even needed if it emits the guildBanAdd event?

Comment on lines +20 to +26
// Remove from database
await client.models.ban.destroy({
where: {
targetId: b.user.id,
guildId: interaction.guild.id
}
});
Copy link
Contributor Author

@totallytavi totallytavi Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as with ban.ts, is this needed since Discord emits the event?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants