Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RegisterMergedDelayedEvent_ToSingleCard #2793

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YiLong-jin
Copy link
Contributor

@YiLong-jin YiLong-jin commented Dec 26, 2024

This modification addresses two issues:

1.In the case of special summoning "クシャトリラ・アライズハート" using the effect of "RUM-ソウル・シェイブ・フォース," it triggered the effect of "幻影騎士団ラスティ・バルディッシュ" to destroy itself, after which the effect of "クシャトリラ・アライズハート" would not activate.
2.The effects triggered by cards in hand when creating a point in time using this function cannot activate if they are triggered after the point in time when the cards are added to hand. At present, there is no hand card to induce effects using this function, if you want to test it needs to temporarily change such cards to call this function to cooperate with the test.

This modification addresses two issues:

In the case of special summoning "クシャトリラ・アライズハート" using the effect of "RUM-ソウル・シェイブ・フォース," it triggered the effect of "幻影騎士団ラスティ・バルディッシュ" to destroy itself, after which the effect of "クシャトリラ・アライズハート" would not activate.
The effects triggered by cards in hand when creating a point in time using this function cannot activate if they are triggered after the point in time when the cards are added to hand.
The aforementioned two errors have been resolved here.The test of the second change needs to be done at the same time as another PR test I submitted, which added this method to "朔夜しぐれ".
YiLong-jin added a commit to YiLong-jin/ygopro-scripts that referenced this pull request Dec 26, 2024
Added RegisterMergedDelayedEvent_ToSingleCard method for some cards in the DP29 branch to fix the large number of unknown options caused by the timing of these cards being induced by multiple cards at the same time.
Should be tested in conjunction with Fluorohydride#2793.
YiLong-jin added a commit to YiLong-jin/ygopro-scripts that referenced this pull request Dec 26, 2024
Added RegisterMergedDelayedEvent_ToSingleCard method for some cards in the DP29 branch to fix the large number of unknown options caused by the timing of these cards being induced by multiple cards at the same time.
Should be tested in conjunction with Fluorohydride#2793
@Wind2009-Louse
Copy link
Contributor

Current bug:
When you remove Despian Tragedy and set Branded Regained, then activate the Branded Regained, the Despian Tragedy can be recycled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants