Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access violation error in cleanup #171

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Fix access violation error in cleanup #171

merged 1 commit into from
Oct 29, 2021

Conversation

sgawarat
Copy link
Contributor

@sgawarat sgawarat commented Oct 7, 2021

When init_table is not called, cleanup_ryzenadj reads uninitialized ry->mem_obj, causing 0xC0000005 error. To fix this, this PR adds the initialization of ry.

@Falcosc
Copy link
Collaborator

Falcosc commented Oct 7, 2021 •
edited
Loading

Does this PR fix #165 ?

Your description sounds like fixing #170 because this example doesn't use the table.

@FlyGoat
Copy link
Owner

FlyGoat commented Oct 8, 2021

I can't imagine a system which can't allocate less than 1k memory...

@bagusnl
Copy link

bagusnl commented Oct 29, 2021

Can confirm this fixed #170

@FlyGoat FlyGoat merged commit 1e7bfea into FlyGoat:master Oct 29, 2021
@bagusnl bagusnl mentioned this pull request Oct 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sgawarat @Falcosc @FlyGoat @bagusnl