Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: follow symlink when searching for cases #2

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

vpmapelli
Copy link
Contributor

Hello,

At least from my undestanding, I believe that the How to use this repo implies that one could create a symbolic link for user's OpenFOAM cases in the same manner that it can be done for tests. I tried it in this manner, but I couldn't get the this expected behavior.

I have tracked down the cause to find command not following links. In that case, the simple addition of -L was enough for the correct inclusion of my cases to the test suite. I am creating this PR for you to evaluate whether it does make sense.

Btw, thank your for your time and this useful framework!

@FoamScience
Copy link
Owner

Thanks for using this thing!
There was a specific reason why cases are supposed to be copied into cases folder, and not symlinked into it.
BUT I don't remember what that reason was, If I can't remember - I'll accept this PR

@FoamScience FoamScience merged commit be09d2a into FoamScience:master Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants