feat: reverse extra args completion #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2c79cd5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
gidonkatten
requested changes
Sep 19, 2024
src/xchain/modules/folks-gmp.ts
Outdated
Comment on lines
73
to
84
| extraArgs: ReverseMessageExtraArgs | undefined, | ||
| extraArgs: Partial<ReverseMessageExtraArgs> | undefined, |
There was a problem hiding this comment.
I don't think there should be the option to pass extra args for the return gas limit
gidonkatten
requested changes
Sep 20, 2024
Resolve #141 Resolve #156 Resolve: > Should subtract from msgValue the existing account's bridge router balanace for retry when a return message is needed > Should subtract from msgValue the existing account's bridge router balanace for reverse - Added completion of retry extraArgs when missing - Added check on retryable actions - Refactored actions types - Added utils to calc requires msg value
gidonkatten
approved these changes
Sep 20, 2024
This was referenced Sep 20, 2024
stefanofa
pushed a commit
that referenced
this pull request
Sep 20, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @folks-finance/[email protected] ### Patch Changes - [#158](#158) [`deef6ce`](deef6ce) Thanks [@palace22](https://github.com/palace22)! - Added retry and reverse msg value estimation considering bridge router balance - [#163](#163) [`468f2d6`](468f2d6) Thanks [@palace22](https://github.com/palace22)! - Fixed retry and reverse message to send - [#158](#158) [`deef6ce`](deef6ce) Thanks [@palace22](https://github.com/palace22)! - Added reverse extra args completion with gas limit estimation - [#158](#158) [`deef6ce`](deef6ce) Thanks [@palace22](https://github.com/palace22)! - Updated SendTokenMessageData to not have the extraneous value folksTokenId - [#158](#158) [`deef6ce`](deef6ce) Thanks [@palace22](https://github.com/palace22)! - Added retry extra args completion with gas limit estimation Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #140
extraArgswhen missingSendTokenMessageDatato not containfolksTokenIdpayloadanddata