Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scopes): prevent unnecessary HTTP call despite caching #702

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

matthv
Copy link
Member

@matthv matthv commented Dec 4, 2024

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

Copy link
Member

@nicolasalexandre9 nicolasalexandre9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codeclimate bot commented Dec 4, 2024

Code Climate has analyzed commit ec979b5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (55% is the threshold).

This pull request will bring the total coverage in the repository to 51.0%.

View more on Code Climate.

@matthv matthv merged commit 5013e2b into main Dec 4, 2024
6 checks passed
@matthv matthv deleted the fix/scope-manager branch December 4, 2024 09:51
forest-bot added a commit that referenced this pull request Dec 4, 2024
## [9.5.4](v9.5.3...v9.5.4) (2024-12-04)

### Bug Fixes

* **scopes:** prevent unnecessary HTTP call despite caching ([#702](#702)) ([5013e2b](5013e2b))
@forest-bot
Copy link
Member

🎉 This PR is included in version 9.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants