fix: handle properly mongo connection close (#209)

src/services/schema/update/analyzer/database-analyzer.js

@@ -37,6 +37,7 @@ module.exports = class DatabaseAnalyzer {
     let analyze;
     if (config.dbDialect === 'mongodb') {
       analyze = this.mongoAnalyzer;
+      databaseConnection = databaseConnection.db();
     } else {
       analyze = this.sequelizeAnalyzer;
     }

src/services/schema/update/database.js

@@ -68,7 +68,6 @@ class Database {
     }
 
     return this.mongodb.MongoClient.connect(connectionUrl, connectionOptionsMongoClient)
-      .then((client) => client.db(options.dbName))
       .catch((error) => this.handleAuthenticationError(error));
   }
 

test/services/analyzer/database-analyzer-mongo.test.js

@@ -73,9 +73,10 @@ describe('services > database analyser > MongoDB', () => {
       expect.assertions(1);
       const mongoHelper = await getMongoHelper(mongoUrl);
       const databaseConnection = await mongoHelper.connect();
+      const db = databaseConnection.db();
       await mongoHelper.dropAllCollections();
-      await databaseConnection.collection('connect_test').insertOne({ name: 'hello' });
-      const doc = await databaseConnection.collection('connect_test').findOne({ name: 'hello' });
+      await db.collection('connect_test').insertOne({ name: 'hello' });
+      const doc = await db.collection('connect_test').findOne({ name: 'hello' });
       await mongoHelper.close();
       expect(doc.name).toStrictEqual('hello');
     });

test/services/analyzer/helpers/mongo-helper.js

@@ -5,16 +5,16 @@ const dbName = 'forest-test';
 
 class MongoHelper {
   constructor(url) {
-    this.url = url;
+    this.url = `${url}/${dbName}`;
   }
 
   connect() {
     this.client = new MongoClient(this.url, { useNewUrlParser: true, useUnifiedTopology: true });
     return new Promise((resolve) => {
       this.client.connect((err) => {
         assert.equal(null, err);
-        this.db = this.client.db(dbName);
-        resolve(this.db);
+        this.db = this.client.db();
+        resolve(this.client);
       });
     });
   }

test/services/database.unit.test.js

@@ -204,29 +204,6 @@ describe('services > database', () => {
       });
     });
 
-    it('should call mongodb db function on successful connection', async () => {
-      expect.assertions(2);
-
-      const mongoDbMock = {
-        db: jest.fn(),
-      };
-      const context = {
-        mongodb: {
-          MongoClient: {
-            connect: jest.fn().mockReturnValue(
-              Promise.resolve(mongoDbMock),
-            ),
-          },
-        },
-      };
-      const database = setupDatabase(context);
-
-      await database.connectToMongodb({ dbName: 'fake' });
-
-      expect(mongoDbMock.db).toHaveBeenCalledTimes(1);
-      expect(mongoDbMock.db).toHaveBeenCalledWith('fake');
-    });
-
     it('should call handleAuthenticationError on a failed connection', async () => {
       expect.assertions(2);