Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle properly mongo connection close #209

Merged
merged 2 commits into from
Jul 23, 2021
Merged

fix: handle properly mongo connection close #209

merged 2 commits into from
Jul 23, 2021

Conversation

arnaud-moncel
Copy link
Member

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • Test manually the implemented changes
  • Review my own code (syntax, style, simplicity, readability)

@slimee
Copy link
Contributor

slimee commented Jul 22, 2021 •
edited
Loading

this PR fixe the problem 💪

Have to check impacts maybe

@slimee
Copy link
Contributor

slimee commented Jul 23, 2021

this PR fixe the problem 💪

Have to check impacts maybe

There are no impacts outside commands projects:create and schema:update, these commands are working 👍

@slimee slimee self-requested a review July 23, 2021 08:36
slimee
slimee approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@slimee slimee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@arnaud-moncel arnaud-moncel merged commit 4a6da5d into master Jul 23, 2021
@arnaud-moncel arnaud-moncel deleted the fix/close-mongo-connection branch July 23, 2021 08:56
forest-bot added a commit that referenced this pull request Jul 23, 2021
@forest-bot
chore(release): 2.2.3 [skip ci]
c5e069b 
## [2.2.3](v2.2.2...v2.2.3) (2021-07-23)

### Bug Fixes

* handle properly mongo connection close ([#209](#209)) ([4a6da5d](4a6da5d))
@forest-bot
Copy link
Member

🎉 This PR is included in version 2.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arnaudbesnier
Copy link
Contributor

Fix #208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimee slimee slimee approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arnaud-moncel @slimee @forest-bot @arnaudbesnier