Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use node 18 and clear pipeline warnings #134

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

Burnett2k
Copy link
Member

@Burnett2k Burnett2k commented Mar 19, 2024

Description

As part of an internal Formidable Open Source audit, we're going through and updating some GH actions to no longer use unsupported versions of node. Also, removing them from our testing pipelines.

I also noticed we weren't utilizing a cache for yarn, so I added that into setup-node action to speed things up slightly.

Checklist:

  • All tests are passing
  • Type definitions, if updated, pass both test-ts-defs and test-ts-usage
  • Benchmark performance has not significantly decreased
  • Bundle size has not been significantly impacted
  • The bundle size badge has been updated to reflect the new size

Copy link

changeset-bot bot commented Mar 19, 2024

⚠️ No Changeset found

Latest commit: 4310e6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (01b5798) to head (ac2c4db).

❗ Current head ac2c4db differs from pull request most recent head 4310e6e. Consider uploading reports for the commit 4310e6e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files           1        1           
  Lines          56       56           
=======================================
  Hits           55       55           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Burnett2k Burnett2k requested a review from carbonrobot March 19, 2024 21:44
@Burnett2k Burnett2k changed the title issue/clear pipeline warnings use node 18 and clear pipeline warnings Mar 19, 2024
@Burnett2k Burnett2k merged commit 6f7d8af into master Mar 20, 2024
2 checks passed
@Burnett2k Burnett2k deleted the issue/clear-pipeline-warnings branch March 20, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants