-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support making nonce nullable #169
Conversation
@@ -48,6 +49,10 @@ export const authorize = ({ | |||
]; | |||
if (Platform.OS === 'android') { | |||
nativeMethodArguments.push(dangerouslyAllowInsecureHttpRequests); | |||
} else { | |||
// add a new useNonce param on iOS to support making it optional | |||
const nonceParamIndex = 5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a bit fiddly, I'd prefer to just add it to the end as the android-only method above
nativeMethodArguments.push(useNonce);
Hi @FelipeBuiles thanks a lot for the PR! Since this is AWS Cognito specific, would you be able to add a config example (something like this). Could you also please add the new parameter to the config. |
94f334d
to
b7e1950
Compare
actually i have this same issue with Dropbox API so I have high hopes for seeing that merged |
ugh... tried @FelipeBuiles fork, now getting So this PR alone won't help me. Also need to turn off PKCE as described in openid/AppAuth-iOS#305 (comment) |
nvm. Dropbox refuses to redirect to urls not starting from |
a08c1f8
to
4a62820
Compare
…end on a change to their codebase
4a62820
to
e0232a9
Compare
same issue moving from 2.4.1, so far so good with this fix. Not cognito and possibly could update a config somewhere in back-end, but this is working for us. might depend on our setup but the experience was the redirect not working on first attempt vs. a complete failure to authenticate. |
Thanks for your help! This has been published in v4.1.0. |
AppAuth-iOS worked correctly with AWS Cognito up until its 0.92 release, later they added support that added support for a nonce parameter. The issue lies in the inabilty of Cognito to handle the nonce parameter (mentioned in their forums here).
There is a comment on the
OIDAuthorizationRequest.h
file from AppAuth-iOS that mentions something about it being nullable:The idea here is to add a new optional param
useNonce
that when set to false, tells the iOS implementation to not generate a nonce attribute automatically. This only happens on the iOS implementation, Android does not have this issue.