Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move js demo examples to ts #2794

Merged
merged 24 commits into from
Feb 12, 2024
Merged

move js demo examples to ts #2794

Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
6be3336
fix error-bar example
Feb 7, 2024
87de270
remove empty data so default candlesticks show
Feb 8, 2024
c5a341f
fix examples in voronai container
Feb 8, 2024
fbd390f
fix cursorcontainer examples
Feb 8, 2024
5032fa3
fixing tooltip demo
Feb 8, 2024
f637ff5
update VictoryCandlestickLabelsType to allow for string
Feb 8, 2024
cd1a239
fix brush container
Feb 8, 2024
e7384ef
sort route list so it's easier to navigate demo
Feb 8, 2024
bc20d08
fix axis
Feb 8, 2024
e200979
fix example for brush line
Feb 8, 2024
ee9f912
add polar axis examples
Feb 8, 2024
178ef6d
add missing examples to pie demo
Feb 9, 2024
a343e48
cleanup and fix label demo
Feb 9, 2024
27b5f34
fix legend demo
Feb 9, 2024
bfafd20
add createContainer
Feb 9, 2024
0cb8374
add createContainer to routes
Feb 9, 2024
6b02654
add external events demo
Feb 9, 2024
5592eb0
add animationDemo
Feb 9, 2024
de88e88
add canvas demo
Feb 9, 2024
531277f
remove references to js demo project
Feb 9, 2024
2f2c40d
delete js demo examples
Feb 9, 2024
758ad00
add changeset
Feb 9, 2024
56ac18a
pr feedback
Feb 12, 2024
29964ad
remove todo left in code
Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/good-zoos-cheat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"victory-brush-container": patch
"victory-candlestick": patch
---

Improve types for brush container and candlestick
5 changes: 1 addition & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,8 @@ $ pnpm install
We have some dev servers available for a sample development environment.

```sh
# JavaScript demo app
$ pnpm start

# TypeScript demo app
$ pnpm start:ts
$ pnpm start
```

These run appropriate file watchers, so you can just start developing source files and wait for the webpack dev server to pick up the new changes.
Expand Down
155 changes: 0 additions & 155 deletions demo/js/app.js
View file
Open in desktop

This file was deleted.

Loading
Loading