-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade doc website to Next14 #2825
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Upgrades the documentation website from react-static to Next14.
Background
The current website is built with
react-static
. Thereact-static
package has long been deprecated and no longer receives support. It has multiple issues with dependencies and will no longer run on Node17+ without using the insecure legacy-ssl option. Our hosting provider for this site is Vercel, which will stop running all Node16 sites in June.At the same time, we recently upgraded our Babel configuration to target modern browsers instead of IE10, which reduces our bundle size significantly. But the version of
react-static
that is available will not compile with modern code due to its embedded webpack config. This meant we could not use a recent version of Victory on our docs site.Next14
This PR attempts to achieve the minimal changes possible to launch a Nextjs site. The previous code was retained as much as possible in most cases. This was achieved roughly by using the Next CLI to generate a base project, copying the existing code into that project as-is, and building out the skeleton for app router.
Notable changes
victory
packages are now pnpm linked into the doc site, so you can develop and test the site locally with code changesreact-live
package and not our oldercomponent-playground
package. This changed the styling/theme of the code editor a little bitInteresting code
Due to the size of the PR and the number of changes, the important part to review here is the actual preview site to look for issues. The code of the documentation site is less crucial for review since most of it is moved files and small adjustments. We can follow up quickly with any problems in a separate PR.
Preview Link: https://victory-git-docs-next-formidable-labs.vercel.app/open-source/victory