Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean theme optimizations #2920

Merged
merged 9 commits into from
Oct 16, 2024
Merged

Clean theme optimizations #2920

merged 9 commits into from
Oct 16, 2024

Conversation

ramenhog
Copy link
Contributor

@ramenhog ramenhog commented Oct 15, 2024

Description

This PR adds a stack bar/area theme demo:
2024-10-15 14 32 13

And also updates the following for the clean theme:

  • Default color should always be the same between all charts
  • Remove pink color
  • Candlestick colors positive and neg should be green and red by default
  • Box plot should use the first two qualitative color scale colors
  • Adjust axis padding
  • Fix broken translucent PadAngle demo

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

These demos have been manually checked on Chrome and Safari on MacOS.

Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: 85461a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
victory-core Minor
victory-area Minor
victory-axis Minor
victory-bar Minor
victory-box-plot Minor
victory-brush-container Minor
victory-brush-line Minor
victory-candlestick Minor
victory-canvas Minor
victory-chart Minor
victory-create-container Minor
victory-cursor-container Minor
victory-errorbar Minor
victory-group Minor
victory-histogram Minor
victory-legend Minor
victory-line Minor
victory-pie Minor
victory-polar-axis Minor
victory-scatter Minor
victory-selection-container Minor
victory-shared-events Minor
victory-stack Minor
victory-tooltip Minor
victory-voronoi-container Minor
victory-voronoi Minor
victory-zoom-container Minor
victory Minor
rn-demo Patch
victory-native Minor
victory-vendor Minor
victory-docs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
victory ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 3:24pm

carbonrobot
carbonrobot previously approved these changes Oct 16, 2024
@carbonrobot carbonrobot self-requested a review October 16, 2024 15:00
@carbonrobot carbonrobot merged commit 7afa44a into main Oct 16, 2024
9 checks passed
@carbonrobot carbonrobot deleted the feat/clean-theme-optimizations branch October 16, 2024 16:02
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants