Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure VictoryPortal id does not change between re-renders #2929

Conversation

gustaff-weldon
Copy link
Contributor

Description

Fixes # (2928)

This PR makes sure generated id of portal does not change during it's lifetime.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I have forked victory and tested the change on my code which was affected by the bug.

Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: 3f15572

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
victory-core Minor
victory-area Minor
victory-axis Minor
victory-bar Minor
victory-box-plot Minor
victory-brush-container Minor
victory-brush-line Minor
victory-candlestick Minor
victory-canvas Minor
victory-chart Minor
victory-create-container Minor
victory-cursor-container Minor
victory-errorbar Minor
victory-group Minor
victory-histogram Minor
victory-legend Minor
victory-line Minor
victory-pie Minor
victory-polar-axis Minor
victory-scatter Minor
victory-selection-container Minor
victory-shared-events Minor
victory-stack Minor
victory-tooltip Minor
victory-voronoi-container Minor
victory-voronoi Minor
victory-zoom-container Minor
victory Minor
rn-demo Patch
victory-native Minor
victory-vendor Minor
victory-docs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
victory ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 9:15pm

@gustaff-weldon gustaff-weldon force-pushed the fix-react-portal-children-multiplication branch from 5854cb9 to 3f15572 Compare October 23, 2024 21:15
@carbonrobot carbonrobot merged commit 5e94c61 into FormidableLabs:main Oct 24, 2024
6 of 7 checks passed
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants