Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: theme builder label options #2948

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Conversation

ramenhog
Copy link
Contributor

@ramenhog ramenhog commented Nov 4, 2024

Description

This PR adds the ability adjust the padding, font size and fill color of a theme's axis labels and also includes a refactor to use tailwind instead of sass for theme builder styles.

I've also removed an unused theme config property for labels since that doesn't seem to actually be used within Victory itself.

2024-11-04 12 09 25

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested on chrome on desktop.

Copy link

changeset-bot bot commented Nov 4, 2024

⚠️ No Changeset found

Latest commit: 44f9a20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Nov 4, 2024 7:38pm

@ramenhog ramenhog merged commit 5060d37 into main Nov 4, 2024
5 checks passed
@ramenhog ramenhog deleted the feat/theme-builder-label-options branch November 4, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants