Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing LESS imports #2512

Closed
wants to merge 1 commit into from
Closed

Conversation

kosmik-koi
Copy link

LESS imports use a .less file extension in order to be compiled

LESS imports use a .less file extension in order to be compiled
@tagliala
Copy link
Member

tagliala commented Dec 2, 2013

@kosmik-koi what the exact issue with this?

I'm using it in my gem and files are correctly compiled: https://github.com/diowa/twbs_less_rails/blob/master/vendor/assets/stylesheets/fontawesome/font-awesome.less

@kosmik-koi
Copy link
Author

I tried using it via grunt-recess to customize some of the variables in our build, and it failed to use the syntax without file extensions.

The LESS documentation http://lesscss.org/#-importing seems to require file extensions on imports for successful compilation.

Making the changes in this commit fixed things for us.

*actually, this appears to be an issue with grunt-recess being based on an older version of LESS (1.3). Adding in the file extensions should provide the maximum compatibility for font-awesome.

@tagliala
Copy link
Member

tagliala commented Dec 3, 2013

Agree, But I have to close this one.

Please edit the proper files inside the src folder: https://github.com/FortAwesome/Font-Awesome/blob/master/src/assets/font-awesome/less/font-awesome.less

Then please recompile assets and make a new pull request against the 4.0.4-wip branch. I suggest you to start working on the 4.0.4-wip branch itself

@davegandy

@tagliala
Copy link
Member

tagliala commented Dec 5, 2013

Closed via 3a461a3

thanks

@tagliala tagliala closed this Dec 5, 2013
@tagliala tagliala added the bug label Apr 1, 2014
@tagliala tagliala modified the milestones: 4.1.0, 4.0.4 Apr 26, 2014
@tagliala tagliala added the css label Apr 27, 2014
@tagliala
Copy link
Member

tagliala commented Jun 7, 2014

@kosmik-koi what about twbs/bootstrap#13542 ?

@tagliala tagliala reopened this Jun 7, 2014
@tagliala tagliala mentioned this pull request Jun 13, 2014
@tagliala
Copy link
Member

@kosmik-koi
reopened here: #3706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants