Merge pull request #58 from Frameworkium/cuke-testid-fix

Fix issue with retrieval of TestCaseId annotation leaving double quot…
Frameworkium · May 10, 2017 · d395a48 · d395a48
2 parents c6a1003 + dd76ec3
commit d395a48
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/src/main/java/com/frameworkium/core/common/listeners/CukeListener.java b/src/main/java/com/frameworkium/core/common/listeners/CukeListener.java
@@ -1,6 +1,8 @@
 package com.frameworkium.core.common.listeners;
 
 import com.frameworkium.core.common.reporting.jira.zapi.Execution;
+
+import cucumber.runtime.CucumberException;
 import cucumber.runtime.StepDefinitionMatch;
 import gherkin.formatter.Formatter;
 import gherkin.formatter.Reporter;
@@ -186,6 +188,9 @@ public void result(Result result) {
             if (resultIsBroken(result)) {
                 scnStepBrokenCount++;
                 latestError = result.getError();
+                if (latestError instanceof CucumberException) {
+                    latestError = latestError.getCause();
+                }
                 lifecycle.fire(new StepFailureEvent().withThrowable(latestError));
             }
             lifecycle.fire(new StepFinishedEvent());
@@ -247,7 +252,8 @@ private Stream<String> retrieveTagStream(List<Tag> tags, String tagName) {
                 .map(name -> name
                         .replace(tagSearch, "")
                         .replace(")", "")
-                        .trim());
+                        .trim()
+                        .replaceAll("^\"|\"$", ""));
     }
 
     private String retrieveTagValue(List<Tag> tags, String tagName) {

diff --git a/src/test/java/com/frameworkium/integration/angularjs/pages/web/DeveloperGuidePage.java b/src/test/java/com/frameworkium/integration/angularjs/pages/web/DeveloperGuidePage.java
@@ -50,6 +50,6 @@ public DeveloperGuidePage clickBootstrapSearchItem() {
     }
 
     public String getGuideTitle() {
-        return guideTitle.getText();
+        return getTitle();
     }
 }
diff --git a/src/test/java/com/frameworkium/integration/angularjs/tests/web/DocumentationTest.java b/src/test/java/com/frameworkium/integration/angularjs/tests/web/DocumentationTest.java
@@ -28,7 +28,7 @@ public void angular_documentation_test() {
                 .getGuideTitle();
 
         assertThat(guideTitle)
-                .isEqualTo("Bootstrap");
+                .contains("Bootstrap");
     }
 
 }