Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Selenium 3.8.1 and removed firefoxProfile property. #91

Merged
merged 5 commits into from
Dec 28, 2017

Conversation

ham1
Copy link
Member

@ham1 ham1 commented Dec 27, 2017

Use -Dwebdriver.firefox.profile instead.

Still need to remove deprecated uses of new XyzDriver(Capabilities)

@codecov
Copy link

codecov bot commented Dec 27, 2017

Codecov Report

Merging #91 into master will increase coverage by 0.25%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #91      +/-   ##
===========================================
+ Coverage     37.15%   37.4%   +0.25%     
  Complexity      279     279              
===========================================
  Files            59      59              
  Lines          1790    1775      -15     
  Branches        169     167       -2     
===========================================
- Hits            665     664       -1     
+ Misses         1032    1019      -13     
+ Partials         93      92       -1
Impacted Files Coverage Δ Complexity Δ
.../frameworkium/core/common/properties/Property.java 87.5% <ø> (-0.2%) 15 <0> (ø)
...kium/core/ui/driver/drivers/LegacyFirefoxImpl.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ameworkium/core/ui/driver/drivers/FirefoxImpl.java 100% <100%> (+70%) 3 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c4868...cd149db. Read the comment docs.

@ham1 ham1 merged commit f0f7b23 into master Dec 28, 2017
@ham1 ham1 deleted the selenium-3.8.1 branch December 28, 2017 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant