Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material: fix Qt6 build failure #11980

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

3x380V
Copy link
Contributor

@3x380V 3x380V commented Jan 14, 2024

QRegExp has been replaced with QRegularExpression and isn't part of the base of Qt6 any more

QRegExp has been replaced with QRegularExpression and isn't part of the base of Qt6 any more
@chennes
Copy link
Member

chennes commented Jan 14, 2024

Thanks for the PR - I thought we had fixed Qt6 compilation with #11795, @davesrocketshop? (Of course, making this change was intended as future work anyway, even given that PR)

@3x380V
Copy link
Contributor Author

3x380V commented Jan 14, 2024

I was surprised too, so I was waiting for a while if someone else notices. For completeness, compiled and tested on Debian GNU/Linux 12 (bookworm). According to documentation, version check is not necessary.

@chennes chennes merged commit 8bc54e2 into FreeCAD:main Jan 18, 2024
10 checks passed
@3x380V 3x380V deleted the fix_material_qt6 branch January 27, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants