Fix build warnings and unit test improvements #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Several calls to
expectProcessLoopCalls
incore_mqtt_utest.c
used theMQTTStateNull
enum instead ofMQTTSuccess
, and resulted in compiler warnings from llvm:Since
expectProcessLoopCalls
has many parameters, it's not obvious from looking at it in each call what each parameter is doing, and whether it's actually necessary. This introduces a structure to holdexpectProcessLoopCalls
' parameters, and only the parameters that are actually used will have to be changed in each invocation.