Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

^ Update YouTube.js to 10.1.0 #5384

Merged
merged 2 commits into from
Jul 10, 2024
Merged

^ Update YouTube.js to 10.1.0 #5384

merged 2 commits into from
Jul 10, 2024

Conversation

PikachuEXE
Copy link
Collaborator

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #5378

Description

  • Update youtube.js
  • Ignore player cache entry < 500 bytes since it's probably broken

Screenshots

N/A

Testing

  • (Optional) In data folder, find folder player_cache, find file b22ef6e7 and ensure it's small (< 500kB), or create an empty file with the same name
  • Watch random video(s) with local API
  • Profit

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@github-actions github-actions bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Jul 10, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) July 10, 2024 07:51
@PikachuEXE PikachuEXE mentioned this pull request Jul 10, 2024
Closed
6 tasks
@ACR-Jeff ACR-Jeff mentioned this pull request Jul 10, 2024
Open
Pistos
Pistos reviewed Jul 10, 2024
View reviewed changes
src/main/index.js

// Probably a corrupted/broken cache entry, pretend it's absent
// A valid entry should be a few KB large
if (contents.byteLength < 500) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could convert the comment into an explanatory constant, like:

      const MIN_VALID_CACHE_ENTRY_SIZE = 500  // or put this higher in the file if you prefer
      if (contents.byteLength < MIN_VALID_CACHE_ENTRY_SIZE) {

@FreeTubeBot FreeTubeBot merged commit b2fe59d into FreeTubeApp:development Jul 10, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 10, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc deleted the update/youtubejs branch July 10, 2024 16:00
OothecaPickle added a commit to OothecaPickle/FreeTube that referenced this pull request Jul 10, 2024
@OothecaPickle
Backport FreeTubeApp#5384 (PikachuEXE)
7c5f7f5
@JimBobSnow JimBobSnow mentioned this pull request Jul 10, 2024
Closed
@ACR-Jeff
Copy link

Tested the latest nightly works great for me, freetube_0.21.0-nightly-4559_linux_portable_x64

@KandiPanda KandiPanda mentioned this pull request Jul 11, 2024
Open
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Jul 11, 2024
@PikachuEXE
Merge branch 'shaka-migration' into custom-builds/shaka
3ab4bc3 
* shaka-migration:
  Truncate long video titles to the screen width in the full screen overlay
  ^ Update YouTube.js to 10.1.0 (FreeTubeApp#5384)
  Fix Invidious API error toasts saying undefined (FreeTubeApp#5380)
  Bump lefthook from 1.6.18 to 1.7.1 (FreeTubeApp#5376)
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Jul 16, 2024
@PikachuEXE
Merge branch 'feature/history-sensitive-search' into custom-builds/cu…
ec4ed68 
…rrent

* feature/history-sensitive-search: (60 commits)
  * Implement case sensitive search in history
  $ Refactor a bit first
  Bump rimraf from 5.0.8 to 6.0.1 (FreeTubeApp#5412)
  Translated using Weblate (Indonesian)
  Bump the babel group across 1 directory with 3 updates (FreeTubeApp#5419)
  Bump sass from 1.77.6 to 1.77.8 (FreeTubeApp#5413)
  Bump webpack from 5.92.1 to 5.93.0 (FreeTubeApp#5414)
  Bump lefthook from 1.7.1 to 1.7.2 (FreeTubeApp#5415)
  Bump electron from 31.1.0 to 31.2.0 (FreeTubeApp#5416)
  Fix about page not reacting to locale changes (FreeTubeApp#5393)
  Delete .github/workflows/report.yml (FreeTubeApp#5395)
  Bump version number to v0.21.1
  Fix Invidious DASH manifest generation (FreeTubeApp#5387)
  ^ Update YouTube.js to 10.1.0 (FreeTubeApp#5384)
  Fix Invidious API error toasts saying undefined (FreeTubeApp#5380)
  Bump lefthook from 1.6.18 to 1.7.1 (FreeTubeApp#5376)
  Bump eslint-plugin-vue from 9.26.0 to 9.27.0 in the eslint group (FreeTubeApp#5371)
  Bump rimraf from 5.0.7 to 5.0.8 (FreeTubeApp#5373)
  Bump npm-run-all2 from 6.2.0 to 6.2.2 (FreeTubeApp#5374)
  Bump marked from 13.0.1 to 13.0.2 (FreeTubeApp#5375)
  ...
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Jul 19, 2024
@PikachuEXE
Merge branch 'development' into feature/subscription-cache
dec3b96 
* development: (59 commits)
  Bump the stylelint group with 2 updates (FreeTubeApp#5411)
  Bump rimraf from 5.0.8 to 6.0.1 (FreeTubeApp#5412)
  Translated using Weblate (Indonesian)
  Bump the babel group across 1 directory with 3 updates (FreeTubeApp#5419)
  Bump sass from 1.77.6 to 1.77.8 (FreeTubeApp#5413)
  Bump webpack from 5.92.1 to 5.93.0 (FreeTubeApp#5414)
  Bump lefthook from 1.7.1 to 1.7.2 (FreeTubeApp#5415)
  Bump electron from 31.1.0 to 31.2.0 (FreeTubeApp#5416)
  Fix about page not reacting to locale changes (FreeTubeApp#5393)
  Delete .github/workflows/report.yml (FreeTubeApp#5395)
  Bump version number to v0.21.1
  Fix Invidious DASH manifest generation (FreeTubeApp#5387)
  ^ Update YouTube.js to 10.1.0 (FreeTubeApp#5384)
  Fix Invidious API error toasts saying undefined (FreeTubeApp#5380)
  Bump lefthook from 1.6.18 to 1.7.1 (FreeTubeApp#5376)
  Bump eslint-plugin-vue from 9.26.0 to 9.27.0 in the eslint group (FreeTubeApp#5371)
  Bump rimraf from 5.0.7 to 5.0.8 (FreeTubeApp#5373)
  Bump npm-run-all2 from 6.2.0 to 6.2.2 (FreeTubeApp#5374)
  Bump marked from 13.0.1 to 13.0.2 (FreeTubeApp#5375)
  Translated using Weblate (Portuguese (Brazil))
  ...
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Jul 19, 2024
@PikachuEXE
Merge branch 'development' into feature/channel-page-update-icon
6938d16 
* development: (78 commits)
  Bump the stylelint group with 2 updates (FreeTubeApp#5411)
  Bump rimraf from 5.0.8 to 6.0.1 (FreeTubeApp#5412)
  Translated using Weblate (Indonesian)
  Bump the babel group across 1 directory with 3 updates (FreeTubeApp#5419)
  Bump sass from 1.77.6 to 1.77.8 (FreeTubeApp#5413)
  Bump webpack from 5.92.1 to 5.93.0 (FreeTubeApp#5414)
  Bump lefthook from 1.7.1 to 1.7.2 (FreeTubeApp#5415)
  Bump electron from 31.1.0 to 31.2.0 (FreeTubeApp#5416)
  Fix about page not reacting to locale changes (FreeTubeApp#5393)
  Delete .github/workflows/report.yml (FreeTubeApp#5395)
  Bump version number to v0.21.1
  Fix Invidious DASH manifest generation (FreeTubeApp#5387)
  ^ Update YouTube.js to 10.1.0 (FreeTubeApp#5384)
  Fix Invidious API error toasts saying undefined (FreeTubeApp#5380)
  Bump lefthook from 1.6.18 to 1.7.1 (FreeTubeApp#5376)
  Bump eslint-plugin-vue from 9.26.0 to 9.27.0 in the eslint group (FreeTubeApp#5371)
  Bump rimraf from 5.0.7 to 5.0.8 (FreeTubeApp#5373)
  Bump npm-run-all2 from 6.2.0 to 6.2.2 (FreeTubeApp#5374)
  Bump marked from 13.0.1 to 13.0.2 (FreeTubeApp#5375)
  Translated using Weblate (Portuguese (Brazil))
  ...

# Conflicts:
#	src/renderer/components/side-nav/side-nav.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pistos Pistos Pistos left review comments

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

@kommunarr kommunarr Awaiting requested review from kommunarr

Assignees
No one assigned
Labels
PR: dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: SyntaxError: Unexpected token (1:47)
7 participants
@PikachuEXE @ACR-Jeff @Pistos @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot