feat: add --force option to forc-wallet new #148
Conversation
There was a problem hiding this comment.
Couple of suggestions for the code. Also I am a little worried as this is a pretty destructive and dangerous operation maybe we shouldn't offer it at all, and force people to remove their wallets explicitly, but happy to see this implemented as well. cc @sdankel
|
@sdankel @kayagokalp GM sir, looking forward for review of the changed code😀 |
Co-authored-by: Sophie Dankel <[email protected]>
Co-authored-by: Sophie Dankel <[email protected]>
Sorry for this, I missed your comment about the test example, I will do it later. |
Co-authored-by: Sophie Dankel <[email protected]>
Co-authored-by: Sophie Dankel <[email protected]>
Co-authored-by: Sophie Dankel <[email protected]>
Co-authored-by: Sophie Dankel <[email protected]>
Co-authored-by: Sophie Dankel <[email protected]>
Co-authored-by: Sophie Dankel <[email protected]>
Co-authored-by: Sophie Dankel <[email protected]>
Co-authored-by: Sophie Dankel <[email protected]>
|
@kayagokalp Hi sir, could you please help me to review the latest code, or can we merge this pr now? |
| )); | ||
| let mut need_replace = String::new(); | ||
| reader.read_line(&mut need_replace).unwrap(); | ||
| if need_replace.trim() == "y" { |
There was a problem hiding this comment.
| if need_replace.trim() == "y" { | |
| if need_replace.trim().to_lowercase() == "y" { |
Nothing to block but we may want to cast to lowercase first, so that both Y and y is accepted.
There was a problem hiding this comment.
I think it's pretty standard that the user has to match the case to choose the non-default option. Any other keypress is equivalent to selecting the default.
…#155) close #150 Refer to [Comment](#148 (comment)) I have reviewed whole forc-wallet project codes, all warning output that using `println!` has changed to `println_warning` ---- ## Screenshots ### For `Password do not match` #### Before  #### After  ### For `Cached address for account` #### Before  #### After 
close #146