Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MessageId with Nonce in message_proof endpoint #1234

Closed
xgreenx opened this issue Jun 30, 2023 · 1 comment · Fixed by #1363
Closed

Replace MessageId with Nonce in message_proof endpoint #1234

xgreenx opened this issue Jun 30, 2023 · 1 comment · Fixed by #1363
Assignees
@MitchTurner
Labels
bug Something isn't working graphql-api Affects API of the GraphQL

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Jun 30, 2023 •
edited
Loading

The message_proof API uses MessageId only to locate the message from the list of messages. It requires the calculation of the MessageId for each receipt. Instead, working directly with Nonce will be more optimal.

We already removed the usage of MessageId everywhere except Merkle proofs. So this change will make our codebase more consistent.
@xgreenx xgreenx added bug Something isn't working graphql-api Affects API of the GraphQL labels Jun 30, 2023
@Voxelot
Copy link
Member

Voxelot commented Aug 22, 2023

@xgreenx plz add description

@MitchTurner MitchTurner self-assigned this Sep 11, 2023
@MitchTurner MitchTurner mentioned this issue Sep 12, 2023
Merged
MitchTurner added a commit that referenced this issue Sep 12, 2023
@MitchTurner
Replace message_id with nonce in MessageProof query (#1363)
7934cbd 
Closes #1234
crypto523 pushed a commit to crypto523/fuel-core that referenced this issue Oct 7, 2024
Replace message_id with nonce in MessageProof query (#1363)
2c2e878 
Closes FuelLabs/fuel-core#1234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MitchTurner MitchTurner

Labels
bug Something isn't working graphql-api Affects API of the GraphQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace message_id with nonce in MessageProof query FuelLabs/fuel-core
3 participants
@Voxelot @MitchTurner @xgreenx