-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed contracts tables to touch only own SMT nodes #1536
Merged
xgreenx
merged 5 commits into
master
from
bugfix/overriding-smt-entries-by-another-contract
Dec 11, 2023
Merged
Fixed contracts tables to touch only own SMT nodes #1536
xgreenx
merged 5 commits into
master
from
bugfix/overriding-smt-entries-by-another-contract
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
previously approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems pretty straightforward, but maybe should wait for @bvrooman to review as well?
bvrooman
previously approved these changes
Dec 11, 2023
Co-authored-by: Brandon Vrooman <[email protected]>
bvrooman
approved these changes
Dec 11, 2023
xgreenx
deleted the
bugfix/overriding-smt-entries-by-another-contract
branch
December 11, 2023 19:08
Merged
xgreenx
added a commit
that referenced
this pull request
Dec 12, 2023
## Version v0.22.0 ### Added - [#1515](#1515): Added support of `--version` command for `fuel-core-keygen` binary. - [#1504](#1504): A `Success` or `Failure` variant of `TransactionStatus` returned by a query now contains the associated receipts generated by transaction execution. #### Breaking - [#1531](#1531): Make `fuel-core-executor` `no_std` compatible. It affects the `fuel-core` crate because it uses the `fuel-core-executor` crate. The change is breaking because of moved types. - [#1524](#1524): Adds information about connected peers to the GQL API. ### Changed - [#1517](#1517): Changed default gossip heartbeat interval to 500ms. - [#1520](#1520): Extract `executor` into `fuel-core-executor` crate. ### Fixed #### Breaking - [#1536](#1536): The change fixes the contracts tables to not touch SMT nodes of foreign contracts. Before, it was possible to invalidate the SMT from another contract. It is a breaking change and requires re-calculating the whole state from the beginning with new SMT roots. ## What's Changed * Added support of `--version` command for `fuel-core-keygen` binary by @xgreenx in #1515 * Weekly `cargo update` by @github-actions in #1518 * feat: Add receipts to transaction status by @bvrooman in #1504 * chore: Update gossip heartbeat interval by @bvrooman in #1517 * Weekly `cargo update` by @github-actions in #1525 * Run beta 4 e2e test each 30 minutes by @xgreenx in #1528 * Fix broken link. by @lukema95 in #1526 * Extract executor into fuel-core-executor crate by @Salka1988 in #1520 * Weekly `cargo update` by @github-actions in #1534 * Make `fuel-core-executor` `no_std` compatible by @Salka1988 in #1532 * Fixed contracts tables to touch only own SMT nodes by @xgreenx in #1536 * Show info about connected peers in the gql api by @Voxelot in #1524 * fix committed gql schema by @Voxelot in #1540 ## New Contributors * @lukema95 made their first contribution in #1526 **Full Changelog**: v0.21.0...v0.22.0
crypto523
pushed a commit
to crypto523/fuel-core
that referenced
this pull request
Oct 7, 2024
## Version v0.22.0 ### Added - [#1515](FuelLabs/fuel-core#1515): Added support of `--version` command for `fuel-core-keygen` binary. - [#1504](FuelLabs/fuel-core#1504): A `Success` or `Failure` variant of `TransactionStatus` returned by a query now contains the associated receipts generated by transaction execution. #### Breaking - [#1531](FuelLabs/fuel-core#1531): Make `fuel-core-executor` `no_std` compatible. It affects the `fuel-core` crate because it uses the `fuel-core-executor` crate. The change is breaking because of moved types. - [#1524](FuelLabs/fuel-core#1524): Adds information about connected peers to the GQL API. ### Changed - [#1517](FuelLabs/fuel-core#1517): Changed default gossip heartbeat interval to 500ms. - [#1520](FuelLabs/fuel-core#1520): Extract `executor` into `fuel-core-executor` crate. ### Fixed #### Breaking - [#1536](FuelLabs/fuel-core#1536): The change fixes the contracts tables to not touch SMT nodes of foreign contracts. Before, it was possible to invalidate the SMT from another contract. It is a breaking change and requires re-calculating the whole state from the beginning with new SMT roots. ## What's Changed * Added support of `--version` command for `fuel-core-keygen` binary by @xgreenx in FuelLabs/fuel-core#1515 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#1518 * feat: Add receipts to transaction status by @bvrooman in FuelLabs/fuel-core#1504 * chore: Update gossip heartbeat interval by @bvrooman in FuelLabs/fuel-core#1517 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#1525 * Run beta 4 e2e test each 30 minutes by @xgreenx in FuelLabs/fuel-core#1528 * Fix broken link. by @lukema95 in FuelLabs/fuel-core#1526 * Extract executor into fuel-core-executor crate by @Salka1988 in FuelLabs/fuel-core#1520 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#1534 * Make `fuel-core-executor` `no_std` compatible by @Salka1988 in FuelLabs/fuel-core#1532 * Fixed contracts tables to touch only own SMT nodes by @xgreenx in FuelLabs/fuel-core#1536 * Show info about connected peers in the gql api by @Voxelot in FuelLabs/fuel-core#1524 * fix committed gql schema by @Voxelot in FuelLabs/fuel-core#1540 ## New Contributors * @lukema95 made their first contribution in FuelLabs/fuel-core#1526 **Full Changelog**: FuelLabs/fuel-core@v0.21.0...v0.22.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to remove the SMT nodes in the foreign contract because it was not prefixed with the
ContractId
. The caller could use the same storage key/asset ID with exactly the same values to delete the SMT nodes in another contract.Fixes #1535