Reuse witnesses for identical secrets when building transactions #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…append a new witness when adding an unsigned coin
# Conflicts: # fuel-tx/src/builder.rs
xgreenx
reviewed
May 24, 2023
We could, although that should go through the specs first. |
xgreenx
previously approved these changes
May 24, 2023
xgreenx
reviewed
May 24, 2023
Co-authored-by: Green Baneling <[email protected]>
xgreenx
approved these changes
May 24, 2023
|
Made a specs ticket here: FuelLabs/fuel-specs#488 |
bvrooman
reviewed
May 25, 2023
| @@ -278,6 +281,20 @@ impl<Tx: Buildable> TransactionBuilder<Tx> { | |||
| self | |||
| } | |||
|
|
|||
| /// Adds a secret to the builder, and adds a corresponding witness if it's a new entry | |||
| #[cfg(feature = "std")] | |||
| fn upsert_secret(&mut self, secret_key: SecretKey) -> u8 { | |||
There was a problem hiding this comment.
upsert - I had to look that one up 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #440 by reusing witness data for matching keys.
It also adds a breaking change by requiring add_unsigned_input for plain transaction (non-builder mode) to specify a witness index instead of naively adding a new witness for each input automatically.