signup, group registerにおいてアイコンをギャラリーから選択できるようにし、アイコンが円形になるように表示させた #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhei-yama
requested changes
Dec 18, 2023
| android:id="@+id/imageAccount" | ||
| android:layout_width="0dp" | ||
| <androidx.cardview.widget.CardView | ||
| android:id="@+id/icon" |
There was a problem hiding this comment.
iconだと他のViewとの差別化をわかりやすくするためにユニークな命名にしましょう！
| android:src="@drawable/img_account" | ||
|
|
||
| <androidx.cardview.widget.CardView | ||
| android:id="@+id/icon" |
There was a problem hiding this comment.
「fragment_signup.xml」と同じようにiconだと他のViewとの差別化をわかりやすくするためにユニークな命名にしましょう！
| private fun openGallary() { | ||
| val intent = Intent(Intent.ACTION_PICK) | ||
| intent.type = "image/*" | ||
| startActivityForResult(intent, REQUEST_GALLARY_TAKE) |
There was a problem hiding this comment.
startActivityForResult()は現在推奨されていない処理なので，
以下の記事を参考にして修正してみてください．
1. startActivityForResultがDeprecatedになった対応方法
2. アクティビティの結果を取得する
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応するissue
概要
意図する動作内容（または変更点）
-↑の画面で表示される画像はスケールが調整され、円形に表示される
スクリーンショット（UI作成，変更時）
その他