Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 395 improve GitHub solver resolver #469

Merged
merged 5 commits into from
Jun 28, 2018

Conversation

nico-ptrs
Copy link
Contributor

@BlackDuckCoPilot
Copy link

BlackDuckCoPilot commented Jun 26, 2018

Black Duck Security Report

Merging #469 into develop will not change security risk.

Click here to see full report

@codecov
Copy link

codecov bot commented Jun 26, 2018

Codecov Report

Merging #469 into develop will decrease coverage by 3.04%.
The diff coverage is 94.87%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #469      +/-   ##
=============================================
- Coverage      57.69%   54.64%   -3.05%     
+ Complexity      1078      808     -270     
=============================================
  Files            284      244      -40     
  Lines           4446     3561     -885     
  Branches         167      120      -47     
=============================================
- Hits            2565     1946     -619     
+ Misses          1794     1536     -258     
+ Partials          87       79       -8
Impacted Files Coverage Δ Complexity Δ
...request/platform/github/scraper/GithubScraper.java 85.71% <100%> (-8.04%) 2 <0> (ø)
...ndrequest/platform/github/parser/GithubResult.java 45.45% <100%> (-4.55%) 5 <1> (-1)
...equest/platform/github/scraper/model/GithubId.java 92.85% <92.85%> (ø) 6 <6> (ø) ⬇️
.../platform/github/scraper/GithubSolverResolver.java 97.29% <95.65%> (-2.71%) 21 <12> (-6)
...structure/exception/ResourceNotFoundException.java 0% <0%> (-100%) 0% <0%> (-1%)
...ore/infrastructure/SecurityContextServiceImpl.java 0% <0%> (-81.25%) 0% <0%> (-7%)
.../io/fundrequest/core/request/fiat/FiatService.java 76.92% <0%> (-18.54%) 5% <0%> (-4%)
...uest/platform/profile/profile/dto/UserProfile.java 22.22% <0%> (-17.78%) 4% <0%> (-4%)
...t/platform/admin/claim/continuous/AutoClaimer.java 89.47% <0%> (-6.18%) 6% <0%> (-1%)
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd920aa...3289cec. Read the comment docs.

@nico-ptrs nico-ptrs merged commit 852e3f1 into develop Jun 28, 2018
@nico-ptrs nico-ptrs deleted the feature-395-improve-github-solver-resolver branch June 28, 2018 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants