Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Title Screen Sys.exit(0) Halting Issue #3196

Closed
2 tasks done
Blue2359 opened this issue Sep 13, 2024 · 12 comments
Closed
2 tasks done

Bug Report: Title Screen Sys.exit(0) Halting Issue #3196

Blue2359 opened this issue Sep 13, 2024 · 12 comments
Labels
status: resolved The issue has been fixed or the suggestion has been implemented. type: minor bug Involves a minor bug or issue.
Milestone

Comments

@Blue2359
Copy link

Issue Checklist

  • I have properly named the issue
  • I have checked the issues/discussions pages to see if the issue has been previously reported

What platform are you using?

Itch.io (Downloadable Build) - Windows

If you are playing on a browser, which one are you using?

None

Version

0.5.0

Context (Provide images, videos, etc.)

The Title Screen itself can halt after pressing the ESCAPE Key to exit the game by calling the Sys.exit(0) method, but it instead just proceeds to halt the entire game itself; without exiting/closing the window instance.

image

Steps to reproduce (or crash logs, errors, etc.)

TitleState.hx => Press ESCAPE: The re-production method.

@Blue2359 Blue2359 added status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue. labels Sep 13, 2024
@NotHyper-474
Copy link
Contributor

Confirmed.

@Hundrec
Copy link
Collaborator

Hundrec commented Sep 19, 2024

Truly a tragedy for the exit game shortcut
image

@Blue2359
Copy link
Author

Blue2359 commented Sep 20, 2024

Now that I think about it, this might be happening because of the crash handler system or whateva' they got goin' on, since thrown exceptions in the 0.5.0 update; (for example, a null obj ref exception inheriting from a scripted/module file) no longer causes the game to close, instead they cause the game to halt.

Note that some thrown errors aren't fatal, and won't cause the game to close immediately after an error inherits from a scripted/module file, i used the null obj ref exception as an example, because that IS a FATAL thrown error/exception.

Which means the game instance itself would have to close down because it wouldn't be able to continue processing!

So deriving from this info, the game instance probably just can't seem to close from something that came with the new source code preventing it.

Edit: Actually, it might be lime's fault...

@amyspark-ng
Copy link
Contributor

still happens in 0.5.1, very sad

@NotHyper-474
Copy link
Contributor

I knew it, it's an issue with Lime: openfl/lime#1803

@AbnormalPoof
Copy link
Collaborator

Is this a Windows-only issue? I can't reproduce this one on macOS.

@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Oct 5, 2024

I can't reproduce it on Linux either so I believe so.

@NotHyper-474
Copy link
Contributor

NotHyper-474 commented Oct 12, 2024

Does this still happen in 0.5.2?

Specially when crashing too

@amyspark-ng
Copy link
Contributor

nope on my part!

@Hundrec
Copy link
Collaborator

Hundrec commented Oct 12, 2024

Yay, pressing escape on the title screen now exits instantly!

@EliteMasterEric EliteMasterEric added status: resolved The issue has been fixed or the suggestion has been implemented. and removed status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. labels Oct 15, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.2 milestone Oct 15, 2024
@NotHyper-474
Copy link
Contributor

While this bug has been solved in Funkin' using a workaround (0d60929) the underlying issue on Lime has been resolved too: openfl/lime@6a40998 which means Funkin's Lime repo can just be fast-forwarded.

Also I think this should be closed since, well, it's been resolved.

@Blue2359
Copy link
Author

Alrighty then, I'll be closing the issue if it's been resolved, thanks!

@Hundrec Hundrec marked this as a duplicate of #3588 Jan 22, 2025
@Hundrec Hundrec marked this as a duplicate of #3209 Jan 23, 2025
@AbnormalPoof AbnormalPoof marked this as a duplicate of #3387 Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: resolved The issue has been fixed or the suggestion has been implemented. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants