Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more functionality to label actions #3771

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Add more functionality to label actions #3771

merged 1 commit into from
Nov 3, 2024

Conversation

Hundrec
Copy link
Collaborator

@Hundrec Hundrec commented Oct 25, 2024 •
edited
Loading

Changes

Ideally, Eric should be able to label something as resolved without having to worry about removing the existing status label or manually closing it.

Additionally, we could make it so that every status label removes every other status label when applied, but I'll only make that change if Eric says he prefers it.

@github-actions github-actions bot added the size: medium A medium pull request with 100 or fewer changes. label Oct 25, 2024
@EliteMasterEric EliteMasterEric added type: documentation Involves improvements or additions to documentation. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. labels Nov 3, 2024
@EliteMasterEric EliteMasterEric self-assigned this Nov 3, 2024
@EliteMasterEric EliteMasterEric merged commit 79188b0 into FunkinCrew:main Nov 3, 2024
4 checks passed
This was referenced Dec 3, 2024
Merged
Closed
charlesisfeline added a commit to charlesmilkjug/Funkin_MixStuff that referenced this pull request Dec 28, 2024
@charlesisfeline
Squashed commit of the following:
f8ae85e 
commit 5480d54
Author: Kade <[email protected]>
Date:   Sat Dec 28 14:40:19 2024 -0800

    Custom render distance strumline

commit bb24821
Author: Eric <[email protected]>
Date:   Wed Dec 18 10:44:01 2024 -0500

    Remove duplicate issue detector. (FunkinCrew#3944)

commit 61a7978
Author: Cameron Taylor <[email protected]>
Date:   Tue Oct 22 12:14:14 2024 -0400

    changelog yoink

commit b5c5693
Author: Cameron Taylor <[email protected]>
Date:   Fri Oct 18 19:51:06 2024 -0400

    proj hxp version bump

commit d6db842
Author: EliteMasterEric <[email protected]>
Date:   Fri Oct 18 17:22:36 2024 -0400

    Fix a typo.

commit ec9ec20
Author: EliteMasterEric <[email protected]>
Date:   Fri Oct 18 17:11:09 2024 -0400

    Update save data format and error handling.

commit 2383fdf
Author: EliteMasterEric <[email protected]>
Date:   Fri Oct 18 16:33:22 2024 -0400

    Remove unused custom type resolver.

commit 36d7de5
Author: EliteMasterEric <[email protected]>
Date:   Fri Oct 18 16:00:06 2024 -0400

    Enable log messages on all builds by default after we got too many complaints.

commit 7f8937d
Author: EliteMasterEric <[email protected]>
Date:   Fri Oct 11 23:52:07 2024 -0400

    Only display the Stage Editor in builds that enable it, and enable it by default (this re-enables the Stage Editor keybind).

commit 4ce83b2
Author: EliteMasterEric <[email protected]>
Date:   Fri Oct 11 23:48:19 2024 -0400

    Updated Save data version to indicate new values.

commit 5173599
Author: EliteMasterEric <[email protected]>
Date:   Fri Oct 11 23:43:57 2024 -0400

    Bump the Stage data version to indicate that new values were added.

commit be08bbe
Author: Hundrec <[email protected]>
Date:   Tue Dec 3 14:21:53 2024 -0800

    Add `status: planned` label to label actions (FunkinCrew#3910)

    * Make label actions more convenient

    * chore: Add status: planned to label actions

commit 9e13ea0
Author: Abnormal <[email protected]>
Date:   Mon Nov 4 18:13:37 2024 +0000

    fixed a plethora of dead links (FunkinCrew#3831)

commit 79188b0
Author: Hundrec <[email protected]>
Date:   Sun Nov 3 12:54:51 2024 -0800

    Make label actions more convenient (FunkinCrew#3771)

commit c0b15ec
Author: Hundrec <[email protected]>
Date:   Wed Oct 23 14:30:52 2024 -0700

    [docs] Add missing changes and links to Changelog (FunkinCrew#3655)

    * changelog sweep

    * Resolve a few conflicts

    * Resolve more conflicts

    * DadBattle

    * Re-add @ianharrigan

    * Add links to 0.5.0

    * Add links and contributors to 0.4.1 and 0.4.0

    * Add links to 0.3.3 and finishing touches

    * Add and polish 0.5.3 changes

    * Make spacing consistent

commit 09b42f3
Author: Eric <[email protected]>
Date:   Fri Oct 11 23:56:17 2024 -0400

    Rewrite CHANGELOG.md for v0.5.2
EliteMasterEric added a commit that referenced this pull request Jan 17, 2025
@EliteMasterEric @Hundrec
@AbnormalPoof @ninjamuffin99
Move changes made in main to develop (#4006)
a08da87 
* Rewrite CHANGELOG.md for v0.5.2

* [docs] Add missing changes and links to Changelog (#3655)

* changelog sweep

* Resolve a few conflicts

* Resolve more conflicts

* DadBattle

* Re-add @ianharrigan

* Add links to 0.5.0

* Add links and contributors to 0.4.1 and 0.4.0

* Add links to 0.3.3 and finishing touches

* Add and polish 0.5.3 changes

* Make spacing consistent

* Make label actions more convenient (#3771)

* fixed a plethora of dead links (#3831)

* Add `status: planned` label to label actions (#3910)

* Make label actions more convenient

* chore: Add status: planned to label actions

* Bump the Stage data version to indicate that new values were added.

* Updated Save data version to indicate new values.

* Only display the Stage Editor in builds that enable it, and enable it by default (this re-enables the Stage Editor keybind).

* Enable log messages on all builds by default after we got too many complaints.

* Remove unused custom type resolver.

* Update save data format and error handling.

* Fix a typo.

* proj hxp version bump

* changelog yoink

* Remove duplicate issue detector. (#3944)

---------

Co-authored-by: Hundrec <[email protected]>
Co-authored-by: Abnormal <[email protected]>
Co-authored-by: Cameron Taylor <[email protected]>
Kade-github pushed a commit to Kade-github/Funkin that referenced this pull request Jan 17, 2025
@EliteMasterEric @Hundrec
@AbnormalPoof @ninjamuffin99 @Kade-github
Move changes made in main to develop (FunkinCrew#4006)
8e0ead6 
* Rewrite CHANGELOG.md for v0.5.2

* [docs] Add missing changes and links to Changelog (FunkinCrew#3655)

* changelog sweep

* Resolve a few conflicts

* Resolve more conflicts

* DadBattle

* Re-add @ianharrigan

* Add links to 0.5.0

* Add links and contributors to 0.4.1 and 0.4.0

* Add links to 0.3.3 and finishing touches

* Add and polish 0.5.3 changes

* Make spacing consistent

* Make label actions more convenient (FunkinCrew#3771)

* fixed a plethora of dead links (FunkinCrew#3831)

* Add `status: planned` label to label actions (FunkinCrew#3910)

* Make label actions more convenient

* chore: Add status: planned to label actions

* Bump the Stage data version to indicate that new values were added.

* Updated Save data version to indicate new values.

* Only display the Stage Editor in builds that enable it, and enable it by default (this re-enables the Stage Editor keybind).

* Enable log messages on all builds by default after we got too many complaints.

* Remove unused custom type resolver.

* Update save data format and error handling.

* Fix a typo.

* proj hxp version bump

* changelog yoink

* Remove duplicate issue detector. (FunkinCrew#3944)

---------

Co-authored-by: Hundrec <[email protected]>
Co-authored-by: Abnormal <[email protected]>
Co-authored-by: Cameron Taylor <[email protected]>
@Hundrec Hundrec added the pr: documentation PR modifies documentation or README files. label Jan 22, 2025
@Hundrec Hundrec added pr: github PR modifies GitHub metadata files. type: github Relates to the management of issues and pull requests on GitHub. and removed type: documentation Involves improvements or additions to documentation. pr: documentation PR modifies documentation or README files. labels Jan 23, 2025
@EliteMasterEric EliteMasterEric added this to the 0.6.0 milestone Jan 23, 2025
MidyGamy pushed a commit to MidyGamy/Funkin that referenced this pull request Jan 27, 2025
@EliteMasterEric @Hundrec
@AbnormalPoof @ninjamuffin99 @MidyGamy
Move changes made in main to develop (FunkinCrew#4006)
1ec1a5d 
* Rewrite CHANGELOG.md for v0.5.2

* [docs] Add missing changes and links to Changelog (FunkinCrew#3655)

* changelog sweep

* Resolve a few conflicts

* Resolve more conflicts

* DadBattle

* Re-add @ianharrigan

* Add links to 0.5.0

* Add links and contributors to 0.4.1 and 0.4.0

* Add links to 0.3.3 and finishing touches

* Add and polish 0.5.3 changes

* Make spacing consistent

* Make label actions more convenient (FunkinCrew#3771)

* fixed a plethora of dead links (FunkinCrew#3831)

* Add `status: planned` label to label actions (FunkinCrew#3910)

* Make label actions more convenient

* chore: Add status: planned to label actions

* Bump the Stage data version to indicate that new values were added.

* Updated Save data version to indicate new values.

* Only display the Stage Editor in builds that enable it, and enable it by default (this re-enables the Stage Editor keybind).

* Enable log messages on all builds by default after we got too many complaints.

* Remove unused custom type resolver.

* Update save data format and error handling.

* Fix a typo.

* proj hxp version bump

* changelog yoink

* Remove duplicate issue detector. (FunkinCrew#3944)

---------

Co-authored-by: Hundrec <[email protected]>
Co-authored-by: Abnormal <[email protected]>
Co-authored-by: Cameron Taylor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: github PR modifies GitHub metadata files. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: github Relates to the management of issues and pull requests on GitHub.
Projects
None yet
Milestone
0.6.0 (Pit Stop 2)
Development

Successfully merging this pull request may close these issues.
2 participants
@Hundrec @EliteMasterEric