Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Note trails position are not updated when moving a note in editor #4120

Open
3 tasks done
amyspark-ng opened this issue Feb 8, 2025 · 4 comments
Open
3 tasks done
Labels
status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue.

Comments

@amyspark-ng
Copy link
Contributor

Issue Checklist

  • I have read the pinned Issues Guide
  • I have checked the Issues/Discussions pages to see if my issue has already been reported
  • I have properly named my issue

Platform

Itch.io (Downloadable Build) - Windows

Browser

None

Version

0.5.3

Description (include any images, videos, errors, or crash logs)

When you move notes in the editor the trail that follows them won't move with them

2025-02-08_13-13-27.mp4

Steps to Reproduce

  1. Open chart editor
  2. Select long notes
  3. Move them
@amyspark-ng amyspark-ng added status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue. labels Feb 8, 2025
@Lasercar
Copy link
Contributor

Lasercar commented Feb 9, 2025

dangit, I close one issue, and 2 more pop up!

Seriously though, I'll investigate this. Maybe it's a simple fix? I don't think it's an easy fix, as regular notes seem to be used for all the stuff and the hold notes are created afterwards at the points of the regular notes.

@amyspark-ng It's been fixed! Though not by me.

@amyspark-ng
Copy link
Contributor Author

it do be like that

do update me how you fix it! i was looking through the code but couldn't find how to fix it, chart editor code is still an enigma for me

@amyspark-ng
Copy link
Contributor Author

https://github.com/FunkinCrew/Funkin/blob/develop/source%2Ffunkin%2Fui%2Fdebug%2Fcharting%2FChartEditorState.hx#L3763 This line seems to be the one that changes the position but being honest i don't really understand how to fix it

@NotHyper-474
Copy link
Contributor

https://github.com/FunkinCrew/Funkin/blob/develop/source%2Ffunkin%2Fui%2Fdebug%2Fcharting%2FChartEditorState.hx#L3763 This line seems to be the one that changes the position but being honest i don't really understand how to fix it

Our goat Kolo already made a PR addressing the issue :) #4127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

No branches or pull requests

3 participants