Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Move the Note Trails when moving a Held Note in the Chart Editor #4127

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

KoloInDaCrib
Copy link
Contributor

Does this PR close any issues? If so, link them below.

#4120

Briefly describe the issue(s) fixed.

Essentially copied some code from the regular notes and applied it to note trails

Include any relevant screenshots or videos.

2025-02-09.15-20-39.mp4

@github-actions github-actions bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. and removed size: medium A medium pull request with 100 or fewer changes. labels Feb 9, 2025
@Lasercar
Copy link
Contributor

Lasercar commented Feb 9, 2025

Ah, I thought I might had to create a null hold note var and then pass a hold note when one is found. Nice work!

Also, you could probably remove that // TODO: Handle selection of hold notes. comment (unless it's for something else?).

@amyspark-ng
Copy link
Contributor

i wonder why the editor handles things this way, im making a similar editor and all notes (regular, long and events) are something called stamps, with this all the behaviour is the same

at least make long notes and regular notes the same class, can't long notes just be a regular note that draws differently if length is not null?

@KoloInDaCrib
Copy link
Contributor Author

i wonder why the editor handles things this way, im making a similar editor and all notes (regular, long and events) are something called stamps, with this all the behaviour is the same

at least make long notes and regular notes the same class, can't long notes just be a regular note that draws differently if length is not null?

SustainTrail uses the rendering system similar to FlxStrip, which is using triangles, vertices and similar to render the notes' graphic instead of rendering it normally like a regular FlxSprite. Granted it is possible to mix them into one class but I think that would've been less readable. Like back before 0.3 every util was using CoolUtil which was executed (rest in peace) in favour of the utils folder simply due to the fact that it's more readable, despite some utils not even being a 100 lines long excluding comments and therefore could've been easily bundled with other utils

@AbnormalPoof AbnormalPoof added topic: chart editor Related to the operation of the Chart Editor. size: medium A medium pull request with 100 or fewer changes. type: minor bug Involves a minor bug or issue. labels Feb 9, 2025
@amyspark-ng
Copy link
Contributor

amyspark-ng commented Feb 10, 2025

so it's basically because the trail has different rendering method and readability?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants