Bump hxCodec commit (fixes Linux issue where it crashes after load) #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noobz4Life
changed the title
hmm.json
Outdated
| @@ -80,7 +80,7 @@ | |||
| "name": "hxCodec", | |||
| "type": "git", | |||
| "dir": null, | |||
| "ref": "c0c7f2680cc190c932a549c2e2fdd9b0ba2bd10e", | |||
| "ref": "2aa654b974507ab51ab1724d2d97e75726fd7d78", | |||
There was a problem hiding this comment.
Probably an oversight but that branch is used by funkin.Vis, not hxCodec. You probably meant to use 61b98a7a353b7f529a8fec84ed9afc919a2dffdd as the hash.
There was a problem hiding this comment.
should be fixed now
NotHyper-474
approved these changes
May 13, 2024
|
Can confirm using the above commit fixes the issue on Linux. |
superpowers04
pushed a commit
to superpowers04/Super-Funkin
that referenced
this pull request
May 18, 2024
Bump hxCodec commit (fixes Linux issue where it crashes after load)
Hundrec
added
status: accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the game will immediately close after loading on Linux builds, but the newest version of hxCodec fixes this
Should fix #2428