Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Re-add out of date screen #2631

Closed
wants to merge 2 commits into from

Conversation

Ethan-makes-music
Copy link
Contributor

@Ethan-makes-music Ethan-makes-music commented May 30, 2024

This works on all platforms from my knowledge!

I re added the out of date screen referenced in #2496 and it may be pretty janky (sorry about that).
The way you can tell it the newest version is by changing the gitVersion.txt to the newest version. And it will show the screen once you press enter in the Title state if the versions do not match

Also did more code clean up in this PR!

I'm probably missing a few instructions but a simple look through the code should kinda explain it.

If this PR ends up getting merged, you need to change the path of the gitVersion.txt to the one in the actual funkin repo instead of it being the path to my fork!

I have only been coding in haxe for a year so apologies :)

@Ethan-makes-music Ethan-makes-music changed the title Re add out of date screen Re-add out of date screen May 30, 2024
@Ethan-makes-music Ethan-makes-music changed the title Re-add out of date screen [FEATURE] Re-add out of date screen May 30, 2024
@aflacc
Copy link

aflacc commented May 30, 2024

re added

wait that was a thing?? what does it look like??

@Ethan-makes-music
Copy link
Contributor Author

re added

wait that was a thing?? what does it look like??

It kind of looks like the Kade and psych screen. It was unused to I just re-added it. Heres what it looks like!

image_2024-05-30_162601492

@EliteMasterEric EliteMasterEric changed the base branch from main to develop June 8, 2024 02:02
@Ethan-makes-music
Copy link
Contributor Author

Ethan-makes-music commented Jun 9, 2024

Bro im so fucking stupid.. accidently just fucking discarded all 14 commits...
Minor setback for major comeback gang 💪💪💪

@AbnormalPoof AbnormalPoof added the status: rejected Issue did not pass review or PR cannot be approved. label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rejected Issue did not pass review or PR cannot be approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants