Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Added combo break and accuracy displays during a song #2681

Closed
wants to merge 1 commit into from

Conversation

Twingamerdudes
Copy link

Adds combo break and accuracy displays right below the health bar like in most FNF engines.

image

@tposejank
Copy link
Contributor

Probably not planned

@charlesisfeline
Copy link

charlesisfeline commented Jun 8, 2024

nah this might break some scripts probably, and besides the devs aint planning for this. yknow you can always make your own, with this feature, however.

@EliteMasterEric EliteMasterEric changed the base branch from main to develop June 8, 2024 02:02
@EliteMasterEric
Copy link
Member

Dave just called you a beta cuck for making this.

@Twingamerdudes
Copy link
Author

😭😭😭

@EliteMasterEric EliteMasterEric added status: rejected Issue did not pass review or PR cannot be approved. and removed wontfix labels Jun 17, 2024
@nebulazorua
Copy link
Contributor

nebulazorua commented Jun 24, 2024

SOMETHING like this should get added tbh
Score on its own is difficult to parse at a glance and doesn't give you any information on if you miss or whatever and I don't like waiting til the end of the song to see if I've FC'd or not without staring at the combo, and staring at the combo is a good way to lose said combo.

I think at least a rank display would be nice?

@charlesisfeline
Copy link

SOMETHING like this should get added tbh Score on its own is difficult to parse at a glance and doesn't give you any information on if you miss or whatever and I don't like waiting til the end of the song to see if I've FC'd or not without staring at the combo, and staring at the combo is a good way to lose said combo.

I think at least a rank display would be nice?

but, why not just get a script that adds it lol

@tposejank
Copy link
Contributor

SOMETHING like this should get added tbh Score on its own is difficult to parse at a glance and doesn't give you any information on if you miss or whatever and I don't like waiting til the end of the song to see if I've FC'd or not without staring at the combo, and staring at the combo is a good way to lose said combo.

I think at least a rank display would be nice?

The results screen is supposed to tell you that sort of statistic

@crowplexus
Copy link

it's called coolhud v-slice by nebulazorua

@charlesisfeline
Copy link

it's called coolhud v-slice by nebulazorua

that or any other hud script for this game

@Squiddu
Copy link

Squiddu commented Jul 19, 2024

Score on its own is difficult to parse at a glance and doesn't give you any information on if you miss or whatever and I don't like waiting til the end of the song to see if I've FC'd or not without staring at the combo, and staring at the combo is a good way to lose said combo.

See, but the thing is there are already indicators of breaking combo, like the pretty prominent miss sound and GF crying.

If that isn't enough for you for whatever reason, I assume the combo might be made easier to see or may have slightly better indication for major combo breaks in the future, but otherwise I figure they don't wanna put too much focus on trying to perfect songs for now.

@nebulazorua
Copy link
Contributor

nebulazorua commented Jul 20, 2024

Score on its own is difficult to parse at a glance and doesn't give you any information on if you miss or whatever and I don't like waiting til the end of the song to see if I've FC'd or not without staring at the combo, and staring at the combo is a good way to lose said combo.

See, but the thing is there are already indicators of breaking combo, like the pretty prominent miss sound and GF crying.

If that isn't enough for you for whatever reason, I assume the combo might be made easier to see or may have slightly better indication for major combo breaks in the future, but otherwise I figure they don't wanna put too much focus on trying to perfect songs for now.

Combo breaking via hitting a Bad or a Shit don't have the gf crying OR the sound, so it's not a good indicator

@EliteMasterEric
Copy link
Member

Combo breaking via hitting a Bad or a Shit don't have the gf crying OR the sound, so it's not a good indicator

In v0.5.0, GF plays her crying animation when you get a combo break via hitting a Bad or Shit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rejected Issue did not pass review or PR cannot be approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants