Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix botplay sustain release bug #2683

Merged
merged 2 commits into from
Jun 8, 2024
Merged

Conversation

Hundrec
Copy link
Collaborator

@Hundrec Hundrec commented Jun 8, 2024

Copied opponent's holdTimer code to the player's side to process hold note animations correctly in Botplay mode

Copied opponent's holdTimer code to the player's side
@EliteMasterEric
Copy link
Member

Tested on stream and LGTM

@EliteMasterEric EliteMasterEric changed the base branch from main to develop June 8, 2024 01:07
@EliteMasterEric EliteMasterEric merged commit 1956636 into FunkinCrew:develop Jun 8, 2024
@EliteMasterEric EliteMasterEric added this to the 0.4.0 milestone Jul 12, 2024
@Hundrec Hundrec added type: minor bug Involves a minor bug or issue. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. labels Jan 22, 2025
@Hundrec Hundrec deleted the patch-1 branch January 26, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants