Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constants pixels per ms #2850

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Use constants pixels per ms #2850

merged 2 commits into from
Sep 16, 2024

Conversation

MaybeMaru
Copy link
Contributor

Replace some missing instances of the value 0.45 with the constant Constants.PIXELS_PER_MS to be a bit more consistent and readable.

@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jun 20, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jun 20, 2024
@EliteMasterEric EliteMasterEric added low priority Does not need urgent attention and may be postponed. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: optimization Involves a performance issue or a bug which causes lag. and removed status: pending triage Awaiting review. labels Jun 20, 2024
@EliteMasterEric EliteMasterEric added the size: small A small pull request with 10 or fewer changes. label Jul 11, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 12, 2024
@EliteMasterEric EliteMasterEric merged commit b8d1341 into FunkinCrew:develop Sep 16, 2024
@MaybeMaru MaybeMaru deleted the constants branch September 21, 2024 11:48
@Hundrec Hundrec removed the low priority Does not need urgent attention and may be postponed. label Jan 22, 2025
@Hundrec Hundrec added the pr: haxe PR modifies game code. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesisfeline charlesisfeline charlesisfeline approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: optimization Involves a performance issue or a bug which causes lag.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MaybeMaru @charlesisfeline @EliteMasterEric @Hundrec