Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Crash after coming back from stickers and pressing F5 #2863

Merged
merged 2 commits into from
Sep 16, 2024
Merged

[BUGFIX] Crash after coming back from stickers and pressing F5 #2863

merged 2 commits into from
Sep 16, 2024

Conversation

gamerbross
Copy link
Contributor

Steps to reproduce

  1. Open the game
  2. Open Story Mode or Freeplay
  3. Get into a song/week
  4. Complete it or leave it
  5. After the sticker transition is done, press F5
  6. Boom crash

This PR just fixes that by checking if the stickers substate isn't destroyed

@EliteMasterEric EliteMasterEric added status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue. labels Jun 20, 2024
@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Jun 29, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jun 29, 2024
@EliteMasterEric EliteMasterEric added the size: small A small pull request with 10 or fewer changes. label Jul 10, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 12, 2024
@5UN4LOWER
Copy link

omg thank you for fixing this it pissed me off sm

@EliteMasterEric EliteMasterEric merged commit 8b96d1b into FunkinCrew:develop Sep 16, 2024
@gamerbross gamerbross deleted the bugfix/stickers-f5-crash branch September 25, 2024 22:51
@Hundrec Hundrec added type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression pr: haxe PR modifies game code. and removed type: minor bug Involves a minor bug or issue. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliteMasterEric EliteMasterEric EliteMasterEric approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gamerbross @5UN4LOWER @EliteMasterEric @Hundrec