Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CODE TWEAK] FunkinSound.playOnce return the created sound #2926

Merged
merged 3 commits into from
Sep 16, 2024
Merged

[CODE TWEAK] FunkinSound.playOnce return the created sound #2926

merged 3 commits into from
Sep 16, 2024

Conversation

gamerbross
Copy link
Contributor

Just makes so FunkinSound.playOnce returns the played sound, cool for later changing pitch or other stuff

@EliteMasterEric EliteMasterEric added type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. labels Jun 29, 2024
@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Jun 29, 2024
@charlesisfeline
Copy link

charlesisfeline commented Jun 29, 2024 •
edited
Loading

image
compiling with this pr, oml the null safety

@gamerbross
Copy link
Contributor Author

image compiling with this pr, oml the null safety

my bad lol

@EliteMasterEric EliteMasterEric self-assigned this Jul 10, 2024
@EliteMasterEric EliteMasterEric added the size: small A small pull request with 10 or fewer changes. label Jul 10, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 12, 2024
@EliteMasterEric EliteMasterEric merged commit 8470880 into FunkinCrew:develop Sep 16, 2024
@gamerbross gamerbross deleted the tweak/funkinsound-playonce-return-value branch September 25, 2024 22:51
@Hundrec Hundrec added the pr: haxe PR modifies game code. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliteMasterEric EliteMasterEric EliteMasterEric approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gamerbross @charlesisfeline @EliteMasterEric @Hundrec