Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Completion Overwrite #3019

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Fix Completion Overwrite #3019

merged 2 commits into from
Oct 1, 2024

Conversation

lemz1
Copy link
Contributor

@lemz1 lemz1 commented Jul 13, 2024 •
edited
Loading

Linked Issues

Closes #2821

Fix

Fixes the issue where the completion is overwritten even though it is smaller. (Issue is described in further detail in #2821)

@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jul 14, 2024
@NotHyper-474 NotHyper-474 mentioned this pull request Sep 18, 2024
Closed
@EliteMasterEric EliteMasterEric added type: minor bug Involves a minor bug or issue. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Sep 25, 2024
@EliteMasterEric EliteMasterEric self-assigned this Sep 25, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.1 milestone Sep 25, 2024
@EliteMasterEric EliteMasterEric merged commit 2fa7cca into FunkinCrew:develop Oct 1, 2024
@Hundrec Hundrec added the size: small A small pull request with 10 or fewer changes. label Jan 22, 2025
@Hundrec Hundrec added the pr: haxe PR modifies game code. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anysad anysad anysad approved these changes

@AbnormalPoof AbnormalPoof AbnormalPoof approved these changes

@AppleHair AppleHair AppleHair approved these changes

@Hundrec Hundrec Hundrec approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.
6 participants
@lemz1 @anysad @AbnormalPoof @AppleHair @Hundrec @EliteMasterEric