[ENHANCEMENT] Freeplay Icon Metadata

[anysad]

Briefly describe the issue(s) fixed.

• This PR aims to fix freeplay pixel icons being hardcoded, and give modders the opportunity to have the name of the icon whatever they want
• This PR also fixes some offsets for the characters in the freeplay menu.

Include any relevant screenshots or videos.

• The freeplay icon metadata takes 4 params: name, scale, flipX and offsets
  

[charlesisfeline]

we already have #2465 but that one has conflicts so eh whatever-

[anysad]

we already have #2465 but that one has conflicts so eh whatever-

Ah, forgot it existed. Will leave this open for Eric to decide which one to use. Also, what conflicts does the PR you mentioned have?

[AbnormalPoof]

#2465 Hasn't been updated to 0.4.x's codebase, which causes it to have merge conflicts... I think?

[MadBear422]

#2465 Hasn't been updated to 0.4.x's codebase, which causes it to have merge conflicts... I think?

The code itself functions fine with the most recent version of the game. The only conflict that it has pertains to the assets repo where I modified some json files to account for the corrected icon offsets. I just need to update that change to be up to date with the newer version of the game

[anysad]

#2465 Hasn't been updated to 0.4.x's codebase, which causes it to have merge conflicts... I think?

The code itself functions fine with the most recent version of the game. The only conflict that it has pertains to the assets repo where I modified some json files to account for the corrected icon offsets. I just need to update that change to be up to date with the newer version of the game

I guess I should close this PR then?

[MadBear422]

#2465 Hasn't been updated to 0.4.x's codebase, which causes it to have merge conflicts... I think?

The code itself functions fine with the most recent version of the game. The only conflict that it has pertains to the assets repo where I modified some json files to account for the corrected icon offsets. I just need to update that change to be up to date with the newer version of the game

I guess I should close this PR then?

I resolved the merge conflicts with my PR. I'd suggest that you leave this one here for Eric to determine whichever one is more suited for the game

[anysad]

#2465 Hasn't been updated to 0.4.x's codebase, which causes it to have merge conflicts... I think?

The code itself functions fine with the most recent version of the game. The only conflict that it has pertains to the assets repo where I modified some json files to account for the corrected icon offsets. I just need to update that change to be up to date with the newer version of the game

I guess I should close this PR then?

I resolved the merge conflicts with my PR. I'd suggest that you leave this one here for Eric to determine whichever one is more suited for the game

Alright, will leave this open for now 🙂

[EliteMasterEric]

Both this and #2465 add data to the opponent character to determine which icon to use, but I was thinking about it and it might make more sense to have the icon be defined by the song metadata?

This would give more flexibility to choose which icon you want for the song in exchange for making it so that you can't define an icon for all of a character's songs at once. Thoughts?

[AbnormalPoof]

Wouldn't that mean that you'd have to define the pixel icon for each song in the metadata, even if multiple songs feature the same opponent? There's also the Character Dropdown in the chart editor to worry about.

[anysad]

I mean as times move on, there might be added a feature that multiple characters sing (different to week5 parents, as just two or more characters, instead of one having -alt), so it might make sense that people want to personally customise for each song?

[anysad]

Besides that, we can just make it use song.characters.opponent if no asset is customly set. (As it is doing right now)

[AbnormalPoof]

This PR appears to have merge conflicts. Please fix them!