[BUGFIX] Player's left notes being selected when they shouldn't

[NotHyper-474]

Does this PR close any issues? If so, link them below.

• Fixes Bug Report: Player's left arrows are always selected along with Opponent's left arrows #2657
• And fixes Selecting the WHOLE opponent section actually selecting left arrows in your section #3072

Briefly describe the issue(s) fixed.

When selecting any part to the left of the chart any left note in the Player's side that is in the vertical boundary of the selection box would be mistakenly selected. This is better demonstrated in the before/after video below.

Include any relevant screenshots or videos.

fnf-bug-before-after.mp4

[Cartridge-Man]

Thank god for this

[Hundrec]

An amazingly simple fix!

[NotHyper-474]

Just found a fix for this too. I don't like how it needs an additional else if check tho Actually I found something that doesn't require another check but nvm

2024-08-06.15-02-54.mp4

[Hundrec]

Perhaps selecting events by highlighting any region on the right should be a quality of life feature! As it stands, it's a little difficult to select only a subset of events without accidentally picking up the player's right arrows as well.

[NotHyper-474]

Perhaps selecting events by highlighting any region on the right should be a quality of life feature! As it stands, it's a little difficult to select only a subset of events without accidentally picking up the player's right arrows as well.

Makes sense, I guess I'll only keep the fix for the left part.

[Hundrec]

Finally in 0.5.1, woo!