Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onSubStateOpenEnd not being called from Substates #3138

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Fix onSubStateOpenEnd not being called from Substates #3138

merged 3 commits into from
Oct 1, 2024

Conversation

lemz1
Copy link
Contributor

@lemz1 lemz1 commented Sep 7, 2024 •
edited
Loading

Does this PR close any issues? If so, link them below.

Fixes #3136

DESCRIPTION

MusicBeatSubState didnt add the callbacks to the substateOpened and substateClosed dispatchers.
This pr adds callbacks to the dispatchers.

@lemz1 lemz1 changed the base branch from main to develop September 7, 2024 17:51
@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Sep 8, 2024
@lemz1 lemz1 changed the title Fix openSubStateEnd not being called from Substates Fix onSubStateOpenEnd not being called from Substates Sep 8, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.1 milestone Sep 19, 2024
@EliteMasterEric EliteMasterEric added type: minor bug Involves a minor bug or issue. topic: mods Related to the creation or use of mods. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Sep 19, 2024
@EliteMasterEric EliteMasterEric self-assigned this Sep 19, 2024
@EliteMasterEric EliteMasterEric merged commit d79e7c8 into FunkinCrew:develop Oct 1, 2024
@Hundrec Hundrec added the size: small A small pull request with 10 or fewer changes. label Jan 22, 2025
@Hundrec Hundrec added the pr: haxe PR modifies game code. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: mods Related to the creation or use of mods. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.

Bug Report: onSubStateOpenEnd not called when entering ResultState
3 participants
@lemz1 @EliteMasterEric @Hundrec