[ENHANCEMENT]: Note Splashes Centering #3433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recommend adding Before/After screenshots, this PR might be a bit confusing for a couple of the reviewers. |
|
I am busy at the moment but will do once I am back! |
|
After images soon, I am finished with my other work, takes a ton of attempts to get the perfect screenshot of the exact frame of the arrow! |
|
I mentioned this in #3105 as well, I hope this gets accepted, just that after the change, the center of the splashes is still not perfectly centered, if I knew how to change it it would help with this. |
|
I like this one a lot |
Hundrec
added
size: small
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
#3105
#3427
#3429
Briefly describe the issue(s) fixed.
The note splashes width offset gets changed from
0.3to0.2Include any relevant screenshots or videos.
Before:
After: