[BUGFIX] Changing song/input offsets no longer causes the game to go all weird #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesisfeline
approved these changes
Oct 3, 2024
never doing editing with github directly again
Cheemsandfriends
added
status: reviewing internally
Cheemsandfriends
added
status: accepted
2 tasks
Hundrec
added
type: major bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
3495
Briefly describe the issue(s) fixed.
Changes a bit of
Conductor's code as well as a bit of code inPlayStateto ensure that the math for offset calculation actually works and doesn't update the game on every beat, thus making the game unplayable with higher offset differences.Include any relevant screenshots or videos.
2024-10-03.13-22-59.mp4
The video shows command prompt box as well as desired song offsets. Command prompt is shown because AbnormalPoof noticed that the bug is caused by a large amounts of updates to resync vocals, which is then traced.